fix: ECR pull through cache pattern #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigobersa
changed the title
bryantbiggs
reviewed
Jul 29, 2024
| @@ -1,3 +1,9 @@ | |||
| locals { | |||
| ecr_account_id = var.ecr_account_id != "" ? var.ecr_account_id : data.aws_caller_identity.current.account_id | |||
There was a problem hiding this comment.
lets remove account ID and region entirely - we can get this data from the provider/data sources
There was a problem hiding this comment.
I kept those as different from the main region/account to illustrate that's possible to use an ECR on a different region/account, not required to be the same as the cluster deployment.
bryantbiggs
reviewed
Jul 29, 2024
bryantbiggs
reviewed
Jul 29, 2024
bryantbiggs
reviewed
Jul 29, 2024
candonov
reviewed
Jul 30, 2024
bryantbiggs
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fit pattern to EKS Blueprints standards.
How was this change tested?
pre-commit run -awith this PRAdditional Notes